Don't mark block complete twice #3487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also sligthly changed the name of the effect to be more suggestive. Signed-off-by: Alexandru Sardan <alexandru@casperlabs.io>
The block accumulator would mark a block completed in storage if it was executed. Since the block is already marked as completed in the reactor control logic after a block is executed and announced and also by the block synchronizer when it's synchronizing historical blocks, there's no need to mark it complete again in the block accumulator. This fixes a bug where the block was marked completed two times in rapid succession. Signed-off-by: Alexandru Sardan <alexandru@casperlabs.io>
Removed ShouldStore::SingleSignature variant for the block acceptor code since it was never used there and refactored the code sligtly for better readablility. Signed-off-by: Alexandru Sardan <alexandru@casperlabs.io>
alsrdn
requested review from
EdHastingsCasperAssociation,
afck,
Fraser999 and
rafal-ch
afck
approved these changes
Dec 14, 2022
| }); | ||
| if response == true { | ||
| harness.send_request(storage, move |responder| { | ||
| BlockCompleteConfirmationRequest { |
There was a problem hiding this comment.
Is that something specific to these tests?
There was a problem hiding this comment.
Not sure if it really needs to mark them complete to be honest. This was changed in 503c4d0 so I wanted to preserve the same semantics due to that change.
rafal-ch
reviewed
Dec 14, 2022
|
Applied the |
Signed-off-by: Alexandru Sardan <alexandru@casperlabs.io>
|
will be addressed by #3520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't mark the block complete from the Block Accumulator component.
This fixes: #3458