Ensure new blocks are marked complete only when strict finality is reached #3549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraser999
requested review from
fizyk20,
EdHastingsCasperAssociation,
georgepisaltu,
alsrdn and
rafal-ch
Comment on lines
95
to
98
| // We don't gossip immediate switch blocks | ||
| if self.is_immediate_switch_block_for_current_protocol_version { | ||
| return StateChange::AlreadySet; | ||
| } |
There was a problem hiding this comment.
Shouldn't this be handled outside the State logic? To keep it simple and compact, I think we should only do basic stuff here like offering getters and setters, let other parts of the code deal with specific logic.
There was a problem hiding this comment.
I'd rather keep it here. The logic isn't complicated and to move it outside would require a getter for is_immediate_switch_block_for_current_protocol_version. If other reviewers agree with you though, I can do the change.
fizyk20
reviewed
Jan 9, 2023
georgepisaltu
approved these changes
Jan 9, 2023
rafal-ch
approved these changes
Jan 10, 2023
fizyk20
approved these changes
Jan 11, 2023
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a small collection of state flags which are carried around with blocks being executed and accumulated.
The state is held in a type named
HotBlock- i.e. a new block which is currently being worked upon. The state is primarily used in the reactor'sdispatch_eventvia theHotBlockAnnouncement. This announcement is made by theContractRuntimeafter executing aFinalizedBlockand by theBlockAccumulatorafter storing a block which has just reached sufficient finality.The introduction of this state has allowed for the removal of some state from the
BlockAccumulatorand also should ensure that actions such as executing a block, storing a block or marking it complete are all done only once per block.It also has allowed the node to avoid needlessly gossiping new immediate switch blocks (all nodes going through an upgrade create the immediate switch block, not just the validators).
Closes #3520.