Add timeouts to juliet crate
#4290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`JulietRpcRequestBuilder`'
… advertised in `README.md`
…cellation has been received
marc-casperlabs
changed the title
juliet crate
Fraser999
approved these changes
Sep 15, 2023
Co-authored-by: Fraser Hutchison <190532+Fraser999@users.noreply.github.com>
marc-casperlabs
merged commit 73fa831
into
casper-network:feat-1.6
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4139.
Adds support for timeouts to the
julietcrate. Note that this function is not yet used in the node (with_timeoutis never called), so there is no direct impact yet.It also renames one function (hence the node change), adds a lot more traceability and some additional tests, fixing some bugs in the process.