Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in the counting of lines of code #14

Closed
j-mortara opened this issue Nov 25, 2018 · 2 comments
Closed

Bug in the counting of lines of code #14

j-mortara opened this issue Nov 25, 2018 · 2 comments
Labels

Comments

@j-mortara
Copy link
Contributor

Hi,

I found a bug in the counting of lines of code. Actually, git-fame only counts one line for a block of lines owned by the same author. Here is an example :

When committing this code, as there is only one author, git-fame counts one line of code.

I propose a correction, which you can see here : https://github.com/trinity357/git-fame (The last three commits are the modifications I applied.)
After these changes, git-fame detects all the lines of code.

May I send you a pull request ?

@casperdcl
Copy link
Owner

Thanks @trinity357 - yes, do open a PR

@casperdcl casperdcl added the bug label Nov 25, 2018
@casperdcl
Copy link
Owner

closed by #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants