Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes quotes for alias registration #56

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Conversation

spier
Copy link
Contributor

@spier spier commented Mar 11, 2021

Fixes #55, as the way that I got the alias to register correctly on OSX is:

git config --global alias.fame '!python -m gitfame'

Please note that
a) I have only tested this on OSX
b) I have not tested if on OSX I even need to register that alias at all

Hope this is still useful.

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #56 (ad86232) into master (06bcb19) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files           3        3           
  Lines         367      367           
  Branches       78       78           
=======================================
  Hits          347      347           
  Misses         17       17           
  Partials        3        3           

@coveralls
Copy link

coveralls commented Mar 11, 2021

Coverage Status

Coverage remained the same at 94.005% when pulling ad86232 on spier:patch-1 into 06bcb19 on casperdcl:master.

@casperdcl
Copy link
Owner

I have not tested if on OSX I even need to register that alias at all

Can you delete the alias (git config --global --unset alias.fame) then try running git fame to see if it still works?

@spier
Copy link
Contributor Author

spier commented Mar 11, 2021

Hah, that also works. So the alias really isn't needed on OSX then.

Not sure if the PR is still useful/valid for others then? Feel free to just close it without merging if it ain't useful.

Thanks for the help, and for the git-fame tool. I will play around with it in the context of this InnerSource pattern, in order to figure out which contributors should get some praise :)

casperdcl added a commit to spier/git-fame that referenced this pull request Mar 11, 2021
@casperdcl
Copy link
Owner

added a note about different OS escapes, thanks :)

@casperdcl casperdcl self-requested a review March 11, 2021 20:49
@casperdcl casperdcl assigned casperdcl and spier and unassigned casperdcl Mar 11, 2021
@spier spier deleted the patch-1 branch March 12, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible documentation glitch: "!python: event not found"
3 participants