refs #987 - Support Phantomjs 2.0 #1137

rdpanek · 2015-01-28T13:00:25Z

PhantomJS 2.0 (non-develop), branch: master, latest revision (a2912c216d06df4d8b51f12ad4082a48c5fc7ba6)

casperjs selftest
...
...
PASS 1022 tests executed in 25.746s, 1022 passed, 0 failed, 0 dubious, 5 skipped.

this is very small victory ;-)

Bud, problem is with Phantomjs. For fully support you must cherry-picked these revision from my repository:

build on Yosemite
https://github.com/rdpanek/phantomjs/commit/c8abe25ce09bfdac995ef9970efe582ad9a79ee5
and fix with webpage.uploadFile bug https://github.com/rdpanek/phantomjs/commit/cb181f564e20b99138cebc3d9194850db4617b6e

This is heavy for production use, but please to code review.

Next steps:

We need to go through all the tests and update.
We need to comapre a new features in Phantom and adding to Casper.

- CoffeeScript isn't supported now

mickaelandrieu · 2015-01-28T13:17:31Z

@rdpanek how about official 2.0 ? https://github.com/ariya/phantomjs/tree/2.0

edit: powned !!! Yata phantomjs 2 is alive ! <3

mickaelandrieu · 2015-01-28T13:21:29Z

modules/casper.js

@@ -1498,8 +1498,9 @@ Casper.prototype.resourceExists = function resourceExists(test) {
            break;
        case "function":
            testFn = test;
-            if (phantom.casperEngine !== "slimerjs")
-                testFn.name = "_testResourceExists_Function";
+            // if (phantom.casperEngine !== "slimerjs") {


We need this to work, what is the issue with slimerjs at this point ?

In this point was problem with bug in Phantom, not Slimer. The code is not removed, because I need your opinion.

After this edit, test passed in both engines.

👍 , CasperJS will be the first and only tool to support triffleJS, phantomJS (1&2) and slimerJS.

mickaelandrieu · 2015-01-28T13:23:45Z

@n1k0 do we need to keep the "coffee support" ? I never see anyone contribute to this files.

rdpanek · 2015-01-28T13:31:38Z

I have problem with build officialy branch 2.0, I work on it.

rdpanek · 2015-01-29T09:54:39Z

@mickaelandrieu we love of coffee - it's very useful, but I understand the reason ariya/phantomjs#12410

sbmaxx · 2015-01-31T07:51:47Z

👍 for support phantomjs 2.0 in casperjs

pskucherov · 2015-01-31T09:23:39Z

👍 for subj

n1k0 · 2015-01-31T09:26:55Z

@mickaelandrieu:

do we need to keep the "coffee support" ? I never see anyone contribute to this files.

Problem is backward compatibility. If it was just me, I'd discard its support, but we need to avoid breaking existing usage.

peter-mouland · 2015-01-31T12:06:07Z

+1

mickaelandrieu · 2015-01-31T17:27:22Z

@n1k0 you are right, but can we plan the next "next" release will drop coffee support ? The easy way will be to release 1.1 without this pull request and then a 1.2 with phantomjs 2 support.

And finally, deprecate 1.0 (the legacy branch will be at least the 1.1). What do you think ?

@rdpanek can you rebase master branch please, and your tests will pass 👍

rdpanek · 2015-02-01T21:40:56Z

@mickaelandrieu I tried rebase my changes on casperjs/master (88c59f8)

PASS 1022 tests executed in 25.426s, 1022 passed, 0 failed, 0 dubious, 5 skipped.

mickaelandrieu · 2015-02-02T09:22:41Z

👍

ohenak · 2015-02-03T06:14:13Z

👍 I can't wait to see this happen!

rdpanek · 2015-02-03T06:33:26Z

@mickaelandrieu sorry, maybe I not understand, but what now? waiting for the milestone, or even on me?

ohenak · 2015-02-03T06:36:55Z

@rdpanek I guess casperjs.exe has to be fixed too? since build failed due to tests for .NET not able to run? Or it is always expected?

rdpanek · 2015-02-03T06:43:11Z

@ohenak I don't know, because, I haven't windows environment. so I do not know the status of

thom4parisot · 2015-02-03T09:32:12Z

Backward compatibility unless you release it as a 2.0.0 branch and drop the support of Phantom 1 as well.

mickaelandrieu · 2015-02-03T09:50:35Z

@oncletom 👍 this may be the best solution.

paazmaya · 2015-02-03T10:40:43Z

Ok, this will would be merged right after releasing 1.1 ?

rdpanek · 2015-02-03T11:02:58Z

@mickaelandrieu @oncletom 👍

rdpanek · 2015-02-09T08:32:58Z

I prepared docker images with functional versions of casperjs and phantomjs2.0

https://registry.hub.docker.com/u/rdpanek/casperjs/ and how to use:

docker run --rm -v `pwd`:/mnt/test rdpanek/casperjs:latest /usr/bin/casperjs test /mnt/test/example.js

mickaelandrieu · 2015-02-09T09:24:54Z

@n1k0 can I create 2.0 branch?

Klimanso · 2015-02-10T12:19:59Z

👍

tamacti · 2015-02-10T12:22:38Z

👍

xescoder · 2015-02-10T12:41:38Z

👍

mickaelandrieu · 2015-02-10T12:45:23Z

@xescoder do someone at Yandex actualy use CasperJS ? o_O

a-x- · 2015-02-10T12:47:56Z

👍

yurich · 2015-02-10T12:48:26Z

👍

nbauma109 · 2015-02-10T14:32:06Z

👍

DimitryDushkin · 2015-02-12T12:30:31Z

👍 from yandex)

mattpacura · 2015-02-13T05:28:08Z

👍

cosmo0920 · 2015-02-18T13:06:27Z

👍

mickaelandrieu · 2015-02-18T13:34:52Z

@rdpanek can you rebase, fix the tests and propose a pull request into "phantomjs-2" branch ?

if @n1k0 agree, I'll rename this branch 2.0. For now, when this new "phantomjs2" branch is all green I will release it as 2.x-alpha.

mickaelandrieu · 2015-03-03T23:12:59Z

ping @n1k0 can we consider that phantomjs 2 and (so on) coffee support discard is the start of CasperJS 2 ?

Surgo · 2015-03-06T01:41:08Z

👍

kevin-smets · 2015-03-06T08:40:36Z

👍

mitar · 2015-03-17T16:17:47Z

+1 for keeping the CoffeeScript support.

mickaelandrieu · 2015-03-17T19:17:45Z

@mitar we can't because phantomjs2 has dropped CoffeeScript support.

pilavdzic · 2015-03-19T18:39:04Z

I can contribute updated install docs if this would be helpful?

See stack overflow answer by pilavdzice for the state of installing on windows:

http://stackoverflow.com/questions/14894311/casperjs-windows-installation-how-is-it-done-the-correct-way-please/29152104#29152104

+1 to remove coffeescript dependency - those who love coffeescript can get the latest version themselves and use that, but it should be optional, having more dependencies is a disadvantage and makes installation more of a barrier to folks who want to just simply start to use casperjs for something simple. This is a very useful tool because it makes things simpler. Phantomjs folks are smart too and did not think it was worth it to have more dependence, so I think it would be good to follow that example.

Can we support coffescript without making it a required dependency?

sbmaxx · 2015-04-14T04:09:51Z

Hey. Maybe it's time to merge this PR? ;)

paazmaya · 2015-04-14T06:42:34Z

Perhaps this PR should be made against the phantomjs-2 branch...

sbmaxx · 2015-04-14T06:49:39Z

I didn't see any progress for a long time. This makes me sad.

mickaelandrieu · 2015-04-14T08:49:35Z

@rdpanek can you make this PR against phantomjs-2 branch please ?

@sbmaxx as there is no "official" gnu/linux build for now, it's hard to test and hard to accept: be patient :)

sbmaxx · 2015-04-14T08:52:47Z

@mickaelandrieu it exists on mac os x, and there is no rocket science in build from source ;) It's about ~15-30 minutes :)

I'll wait..

n1k0 · 2015-04-14T09:07:43Z

it exists on mac os x, and there is no rocket science in build from source ;) It's about ~15-30 minutes :)

So while you seem quite comfortable doing this, thanks for sending a PR with the travis.yml file tweaked so we can build Phantom2 there and run the unit test suite. Thanks again, we truly appreciate.

jchoi18 · 2015-07-01T19:26:40Z

Any update on this branch? I'd love to be able to use the window.performance feature in Phantom2.0 with casperjs

istr · 2015-12-01T17:04:36Z

Closed with PR 1310 and PR 1352.

Radim Daniel Panek added 3 commits January 12, 2015 11:20

PhantomJS2.0

cd99be6

Casper selftest: agent: headers: specification of test and message

5ed2fc5

Fix for work with Phatnomjs2.0

b592a64

- CoffeeScript isn't supported now

mickaelandrieu reviewed Jan 28, 2015
View reviewed changes

mickaelandrieu added Enhancement PhantomJS labels Jan 28, 2015

mickaelandrieu added this to the 1.1 milestone Jan 28, 2015

mickaelandrieu modified the milestones: 2.0.x, 1.1 Feb 3, 2015

paazmaya modified the milestones: 2.0, 2.0.x Mar 6, 2015

cosmo0920 mentioned this pull request Apr 15, 2015

Change dependency for CasperJS Homebrew/legacy-homebrew#38632

Closed

istr mentioned this pull request Nov 22, 2015

Support for phantomjs 2.0.0 and 2.0.1 pre-release with fileupload bugfix #1352

Merged

istr closed this Dec 1, 2015

refs #987 - Support Phantomjs 2.0 #1137

refs #987 - Support Phantomjs 2.0 #1137

Conversation

rdpanek commented Jan 28, 2015

mickaelandrieu commented Jan 28, 2015

mickaelandrieu Jan 28, 2015

Choose a reason for hiding this comment

rdpanek Jan 28, 2015

Choose a reason for hiding this comment

mickaelandrieu Jan 28, 2015

Choose a reason for hiding this comment

rdpanek Jan 28, 2015

Choose a reason for hiding this comment

paazmaya Jan 28, 2015

Choose a reason for hiding this comment

mickaelandrieu commented Jan 28, 2015

rdpanek commented Jan 28, 2015

rdpanek commented Jan 29, 2015

sbmaxx commented Jan 31, 2015

pskucherov commented Jan 31, 2015

n1k0 commented Jan 31, 2015

peter-mouland commented Jan 31, 2015

mickaelandrieu commented Jan 31, 2015

rdpanek commented Feb 1, 2015

mickaelandrieu commented Feb 2, 2015

ohenak commented Feb 3, 2015

rdpanek commented Feb 3, 2015

ohenak commented Feb 3, 2015

rdpanek commented Feb 3, 2015

thom4parisot commented Feb 3, 2015

mickaelandrieu commented Feb 3, 2015

paazmaya commented Feb 3, 2015

rdpanek commented Feb 3, 2015

rdpanek commented Feb 9, 2015

mickaelandrieu commented Feb 9, 2015

Klimanso commented Feb 10, 2015

tamacti commented Feb 10, 2015

xescoder commented Feb 10, 2015

mickaelandrieu commented Feb 10, 2015

a-x- commented Feb 10, 2015

yurich commented Feb 10, 2015

nbauma109 commented Feb 10, 2015

DimitryDushkin commented Feb 12, 2015

mattpacura commented Feb 13, 2015

cosmo0920 commented Feb 18, 2015

mickaelandrieu commented Feb 18, 2015

mickaelandrieu commented Mar 3, 2015

Surgo commented Mar 6, 2015

kevin-smets commented Mar 6, 2015

mitar commented Mar 17, 2015

mickaelandrieu commented Mar 17, 2015

pilavdzic commented Mar 19, 2015

sbmaxx commented Apr 14, 2015

paazmaya commented Apr 14, 2015

sbmaxx commented Apr 14, 2015

mickaelandrieu commented Apr 14, 2015

sbmaxx commented Apr 14, 2015

n1k0 commented Apr 14, 2015

jchoi18 commented Jul 1, 2015

istr commented Dec 1, 2015