Introduce fillLabels method to fill out a form based on label text. #948
Conversation
|
What do you guys think? Any feedback on this? |
|
A good idea, but I don't have time (for now) to review. |
|
Somehow I missed this PR. Very interesting approach, I'll review this soon :) |
|
👍 Thanks! I've been using it for the last month or so, and its really improved the feel of our acceptance tests. |
|
@n1k0 I may need this one, do you have enough time this week for this ? |
| labels: function(labelText, formSelector, value) { | ||
| var label = this.findOne({type: "xpath", path: '//label[text()="' + labelText + '"]'}, form); | ||
| if(label && label.htmlFor) { | ||
| return this.findAll('#' + label.htmlFor, form); |
There was a problem hiding this comment.
How this will "react" if the label doesn't have for attribute ?
There was a problem hiding this comment.
Good eye. It currently will not work with labels that are simply wrapping inputs, only labels that use the for attribute. If this PR gets merged, I will push an additional PR in the future to add this functionality.
|
Thanks for the review, @mickaelandrieu! @n1k0 let me know if there's anything additional I can do to help this get merged. |
|
ping @n1k0 can I merge it or do you want to review this one before ? |
|
@n1k0 did you have time to take a look ? |
|
@mickaelandrieu Done. Thanks for stewarding this PR along! |
Introduce fillLabels method to fill out a form based on label text.
|
Thanks @botandrose |
Revert "REFS #948 - Add docs"
Hi folks! I've begun using it to write acceptance tests, and its a much better tool for this purpose than all the others that I've tried in JavaScript-land. So, thank you for CasperJS!
So, from the standpoint of using CasperJS as a tool to write acceptance tests, I have found one area for improvement. The problem is that the methods for interacting with forms and form elements require direct knowledge of the underlying html, specifically the name attribute of the inputs. Since acceptance tests are written from the standpoint of a non-technical user, and non-technical users don't know anything about html, css selectors, etc; associated label text is a better way of calling out form elements. This strategy also reduces the coupling between the acceptance test and the app, promoting refactoring of the html and css.
This branch is an attempt at adding this behavior to CasperJS, in the form of new fillLabels method. What do you guys think?