Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support for 3D structure functions #15

Merged
merged 62 commits into from
Jul 24, 2024
Merged

WIP: Support for 3D structure functions #15

merged 62 commits into from
Jul 24, 2024

Conversation

cassidymwagner
Copy link
Owner

@cassidymwagner cassidymwagner commented May 17, 2024

This feature will calculate structure functions for 3D velocity data, likely from LES data.

TODO:

  • 3D advection
  • 3D shift array
  • 3D separation distances
    • Only for uniform idealized simulations, not worrying about latlon data for now.
  • 3D structure functions
    • Traditional
    • Advective
  • 3D parent function
  • Tests
  • Documentation/docstring
    • Docstring should be in a good spot

@cassidymwagner
Copy link
Owner Author

For calculate_structure_function_3d, need to think traditional structure functions with z dimension.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 85.46099% with 41 lines in your changes missing coverage. Please review.

Project coverage is 92.37%. Comparing base (8145a1f) to head (ae0ca0b).

Files Patch % Lines
fluidsf/generate_structure_functions_3d.py 76.78% 39 Missing ⚠️
fluidsf/generate_structure_functions_1d.py 60.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (8145a1f) and HEAD (ae0ca0b). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (8145a1f) HEAD (ae0ca0b)
9 6
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   98.19%   92.37%   -5.82%     
==========================================
  Files          10       15       +5     
  Lines         332      590     +258     
==========================================
+ Hits          326      545     +219     
- Misses          6       45      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cassidymwagner
Copy link
Owner Author

After pulling the bug fix from #26 I double-checked calculate_structure_function_3d and the traditional structure functions are calculated correctly already, so no updates necessary.

@cassidymwagner
Copy link
Owner Author

Since all of the tests pass I'm going to merge this now and continue working on any documentation or further testing either in #23 or a new branch, respectively.

@cassidymwagner cassidymwagner merged commit e3b2806 into main Jul 24, 2024
13 of 16 checks passed
@BrodiePearson BrodiePearson deleted the 3D_sfs branch August 5, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants