Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array shifting bug fix #27

Merged
merged 20 commits into from
Jul 16, 2024
Merged

Array shifting bug fix #27

merged 20 commits into from
Jul 16, 2024

Conversation

cassidymwagner
Copy link
Owner

@cassidymwagner cassidymwagner commented Jul 12, 2024

This PR will fix a bug that shifted the arrays in an inconsistent direction, resulting in flipped signs for some of the structure functions. I'm also including updated tests (WIP) that evaluate the code against analytical solutions, which will be a more robust method of testing.

TODO:

  • Lat-lon tests
  • Periodic domain tests
    • LL tests
    • LLL tests:
      • some work in progress

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 99.08257% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.58%. Comparing base (5a5201f) to head (ff05488).

Files Patch % Lines
fluidsf/generate_structure_functions.py 98.52% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   99.16%   99.58%   +0.42%     
==========================================
  Files           8        8              
  Lines         239      242       +3     
==========================================
+ Hits          237      241       +4     
+ Misses          2        1       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cassidymwagner cassidymwagner merged commit 1a75001 into main Jul 16, 2024
14 of 16 checks passed
@cassidymwagner cassidymwagner deleted the shift_bug_fix branch July 16, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant