TCastleTheme.Images as TCastleImagePersistent #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaliskambi
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
Great, thank you!
And thanks for catching broken TCastleImagePersistent.SetSmoothScaling by the way too.
This should cleanup some examples, since now one can just set image URL and it will work naturally, it will also use cache, it will also automatically make OwnsImage to true.
michaliskambi
added a commit
that referenced
this pull request
Mar 1, 2021
TCastleImagePersistent has already ProtectedSides Also simplify fps_game/gameinitialize.pas code now See #254
|
I updated https://castle-engine.io/manual_2d_user_interface.php#section_theme about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
TCastleImagePersistentinstead ofTCastleImageinTCastleTheme, e.g. to allow pixelart splash screens, etc.Also fix a bug with
TCastleImagePersistent.SmoothScalingnot being applied if set runtime.Should fix https://trello.com/c/lNJYLskZ/129-theme-images-as-tcastleimagepersistent