Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update library interface with new function to set navigation input shortcuts #566

Merged
merged 5 commits into from Feb 1, 2024

Conversation

janadamec1
Copy link
Member

Changes to (deprecated) library:

  1. new exported function to set InputShortcuts to Navigation
  2. Fixed crash bug when reopening the scene using library interface (nilling MainScene pointer after close)
  3. Better exception reporting - function name added

I've tested the functionality inside my app.

This pull request also fixes compilation of C++ example applications using the library interface (cpp_winapi_library_tester, qt_library_tester). I've also added some Visual Studio folders (used in cpp_winapi_library_tester) to gitignore to have the clean output.

Thanks

@michaliskambi
Copy link
Member

Thank you very much! I noticed your work in the branch yesterday. All perfect, no comments, applying :)

In particular thanks for the if Navigation.Camera <> nil then -> if Navigation.Camera = nil then fix in castlescenecore.pas, that was a dumb mistake from my part. It seems I did it during 8145ad2 , and I mistakenly used <> instead of = and never checked whether it works.

Note that we have a a number of automatic tests in CGE in tests subdirectory, if you want to add a test making a AddViewpointFromNavigation call (to make sure that such simple mistake will never again occur in the future), you're welcome!

@michaliskambi michaliskambi merged commit 73b4bc0 into master Feb 1, 2024
31 of 33 checks passed
@michaliskambi michaliskambi deleted the library-update branch February 1, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants