Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove item from queue when iterating #20

Merged
merged 1 commit into from Feb 27, 2019

Conversation

sebastiansimson
Copy link
Contributor

If there was invalid data read for the queue and the resulting object is null, do not add to batch request. Make sure that the right number of events is removed after batch request, including the invalid data.

@codecov-io
Copy link

Codecov Report

Merging #20 into master will increase coverage by 0.15%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #20      +/-   ##
============================================
+ Coverage     79.81%   79.96%   +0.15%     
  Complexity      154      154              
============================================
  Files            25       25              
  Lines           530      529       -1     
  Branches         26       26              
============================================
  Hits            423      423              
+ Misses           82       81       -1     
  Partials         25       25
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/castle/android/queue/EventQueue.java 54.32% <66.66%> (+0.66%) 16 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a4dfe5...eb1b683. Read the comment docs.

@aalekz aalekz merged commit 101e0c5 into master Feb 27, 2019
@aalekz aalekz deleted the fix/invalid-queue-removal branch February 27, 2019 08:45
@sebastiansimson sebastiansimson restored the fix/invalid-queue-removal branch February 27, 2020 11:38
@sebastiansimson sebastiansimson deleted the fix/invalid-queue-removal branch February 27, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants