Create parallel data structure for types to fasten up lookups later. #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonorossi
requested changes
Aug 2, 2022
jonorossi
requested changes
Aug 2, 2022
src/Castle.Windsor/MicroKernel/Registration/ComponentRegistration.cs
Outdated
Show resolved
Hide resolved
src/Castle.Windsor/MicroKernel/Registration/ComponentRegistration.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jonathon Rossi <jono@jonorossi.com>
Co-authored-by: Jonathon Rossi <jono@jonorossi.com>
Co-authored-by: Jonathon Rossi <jono@jonorossi.com>
Co-authored-by: Jonathon Rossi <jono@jonorossi.com>
Co-authored-by: Jonathon Rossi <jono@jonorossi.com>
…ion.cs Co-authored-by: Jonathon Rossi <jono@jonorossi.com>
…ion.cs Co-authored-by: Jonathon Rossi <jono@jonorossi.com>
|
All your proposed changes are commited. |
jonorossi
approved these changes
Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When profiling application build times I noticed that a lot of my performance went into a List.Contains call.
This seems like a problem that's easily solved. I'm well aware that I might have missed some detail here, but this kind of change would bring a lot of performance to applications registering a lot of components.
This is just a rough draft, but I would be very much interested in your input and explanations.
Thank you!