Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indentation size #16

Closed
lintool opened this issue Oct 14, 2015 · 2 comments
Closed

Indentation size #16

lintool opened this issue Oct 14, 2015 · 2 comments

Comments

@lintool
Copy link
Member

lintool commented Oct 14, 2015

@iorixxx Do you mind if we agree on code indentation being two spaces, just to be consistent?

If so, can you please reformat your code? I'd rather you do it so better retain history for git blame. Please send pull request.

Thanks!
iorixxx added a commit to iorixxx/Anserini that referenced this issue Oct 15, 2015
@iorixxx
issue castorini#16: make indent 2 spaces, and remove unused dependency
09e4fa5
@lintool
Copy link
Member Author

lintool commented Oct 15, 2015

Merged 09e4fa5

@lintool lintool closed this as completed Oct 15, 2015
@iorixxx
Copy link
Contributor

iorixxx commented Oct 15, 2015

Ups commons cli dependency (that I removed) was still used, didn't know that.

@lintool lintool mentioned this issue Oct 20, 2015
Merged
@castorini castorini locked as resolved and limited conversation to collaborators Nov 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lintool @iorixxx