Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyzer refactoring: single analyzer to handle stem/no stem and stopwords #1027

Merged
merged 3 commits into from
Mar 7, 2020

Conversation

lintool
Copy link
Member

@lintool lintool commented Mar 7, 2020

@chriskamphuis instead of a separate class for no-stemming, I think this is much cleaner.

@edwinzhng I think this is a much clear way to construct non-stemming analyzers, rather than the previous way.

Copy link
Collaborator

@chriskamphuis chriskamphuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I assume this breaks Pyserini right?

@lintool
Copy link
Member Author

lintool commented Mar 7, 2020

@chriskamphuis yup - once this is merged we have to make changes to Pyserini again...

@codecov
Copy link

codecov bot commented Mar 7, 2020

Codecov Report

Merging #1027 into master will increase coverage by 0.25%.
The diff coverage is 68.29%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1027      +/-   ##
============================================
+ Coverage     40.91%   41.17%   +0.25%     
- Complexity      551      560       +9     
============================================
  Files           128      127       -1     
  Lines          7659     7662       +3     
  Branches       1129     1132       +3     
============================================
+ Hits           3134     3155      +21     
+ Misses         4212     4193      -19     
- Partials        313      314       +1     
Impacted Files Coverage Δ Complexity Δ
...a/io/anserini/analysis/DefaultEnglishAnalyzer.java 75.00% <0.00%> (ø) 9.00% <0.00%> (?%)
...java/io/anserini/ltr/feature/CountBigramPairs.java 87.01% <0.00%> (+22.07%) 31.00% <0.00%> (+8.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a10da9...f9c24f5. Read the comment docs.

Copy link
Member

@edwinzhng edwinzhng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lintool lintool merged commit 2e9b267 into master Mar 7, 2020
@lintool lintool deleted the analyzer-refactoring branch March 7, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants