Add option to enable Lucene 8 index compatibility #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1953 +/- ##
============================================
- Coverage 60.10% 60.09% -0.02%
Complexity 1061 1061
============================================
Files 178 178
Lines 9886 9891 +5
Branches 1370 1371 +1
============================================
+ Hits 5942 5944 +2
- Misses 3439 3441 +2
- Partials 505 506 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My solution to #1952 is to add a flag
-lucene8that abandons consistent tie breaking, so retrieval doesn't need to touch the docvalues. In the regression script, a similar option--lucene8allows the score matching to be more lenient.