Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix submodule name to be consistent with pyserini, minor changes to get it to work #45

Merged
merged 2 commits into from
Jun 1, 2020

Conversation

ronakice
Copy link
Member

@ronakice ronakice commented Jun 1, 2020

Rename, change eval/ to eval in the path. Seems to only work for me if I do this

@ronakice
Copy link
Member Author

ronakice commented Jun 1, 2020

@rodrigonogueira4 can you try: git submodule update --init --recursive once you clone this branch to verify?

@lintool
Copy link
Member

lintool commented Jun 1, 2020

this seems to be consistent with pyserini: https://github.com/castorini/pyserini/blob/master/.gitmodules

@rodrigonogueira4
Copy link
Member

@rodrigonogueira4 can you try: git submodule update --init --recursive once you clone this branch to verify?

It worked!

Copy link
Member

@rodrigonogueira4 rodrigonogueira4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ronakice ronakice merged commit f204e4b into master Jun 1, 2020
@ronakice ronakice deleted the rename-submodule branch June 1, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants