Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CovidQA Doc #56

Merged
merged 8 commits into from
Jul 13, 2020
Merged

Create CovidQA Doc #56

merged 8 commits into from
Jul 13, 2020

Conversation

HangCui0510
Copy link
Contributor

No description provided.

Copy link
Member

@ronakice ronakice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename the markdown file to match that format of msmarco-doc/msmarco. Also, let's remove the CovidQA stuff from the README

docs/CovidQA.md Outdated
mrr@10 0.22846344887161213
```

It takes about 10 seconds to re-rank this subset on CovidQA using a P100.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BM25 is not GPU dependent

requirements.txt Outdated
tqdm==4.45.0
transformers>=2.9.0
transformers==2.10.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any reason of why we don't want the latest transformers and tokenizers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this error using latest transformers and tokenizers
Screen Shot 2020-07-13 at 2 50 08 PM

Copy link
Member

@ronakice ronakice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aight! Looks good to me, thanks for doing this! I'll let Rodrigo review it before I merge!

Copy link
Member

@rodrigonogueira4 rodrigonogueira4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ronakice ronakice merged commit ed96740 into castorini:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants