Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default args in MonoBERT/T5 #92

Merged
merged 1 commit into from
Sep 20, 2020
Merged

Conversation

yuxuan-ji
Copy link
Contributor

I did a text replace at one point and must've overwritten these default values

the correct paths are castorini/monot5-base-msmarco and 'castorini/monobert-large-msmarco'. sorry for this!

@ronakice ronakice self-requested a review September 20, 2020 18:25
Copy link
Member

@ronakice ronakice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, thanks for catching this. merging

@ronakice ronakice merged commit 73539ea into castorini:master Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants