Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve unittest issues #1616

Closed
ArthurChen189 opened this issue Sep 2, 2023 · 6 comments
Closed

Resolve unittest issues #1616

ArthurChen189 opened this issue Sep 2, 2023 · 6 comments
Assignees
@ArthurChen189

Comments

@ArthurChen189
Copy link
Member

ArthurChen189 commented Sep 2, 2023 •
edited
Loading

inconsistent method names with test_encoder.py, due to refactoring the ONNX query encoder in Anserini
@ArthurChen189 ArthurChen189 self-assigned this Sep 2, 2023
@ArthurChen189 ArthurChen189 mentioned this issue Sep 2, 2023
Merged
@lintool
Copy link
Member

lintool commented Sep 2, 2023

Unit tests for me... did you update your branch?

@ArthurChen189
Copy link
Member Author

Hrmm weird. And yeah, my branch is up-to-date with the castorini upstream

@ArthurChen189
Copy link
Member Author

I ran the unittest with anserini 0.22.0's fatjar on both my local end and ORCA....

@SumonKantiDey
Copy link

How much time does it take to complete the unit test? I am trying the unit test with anserini-0.22.1-SNAPSHOT-fatjar.jar but somehow it takes a significant amount of time.

@lintool
Copy link
Member

lintool commented Sep 4, 2023 

Ran 308 tests in 321.069s

OK

On my main dev machine:

Screen Shot 2023-09-04 at 5 31 20 PM

@lintool
Copy link
Member

lintool commented Sep 4, 2023

Closing issue since #1617 has been merged.

@lintool lintool closed this as completed Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArthurChen189 ArthurChen189

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lintool @SumonKantiDey @ArthurChen189