Updates/fixes to factions and epilogues

[chaosvolt]

Summary

SUMMARY: Content "Add faction strength to faction window, fix redundant faction epilogues, rewrite some epilogues and flesh out Old Guard epilogues"

Purpose of change

Port over what turns out to be an easy JSON fix for faction epilogues being broken. Also port over a couple epilogues for factions lacking them. And what I'd been particularly eager to do, make the writing for the "good" endings either actually good or ideally ambiguous. Bare minimum being "not as bad or worse than the baseline ending"

Describe the solution

1. Ported over faction epilogues for Hub 01 and the Isherwoods.
2. Fix faction epilogues potentially displaying both the good end and bad end due to the bad end not having power_max defined.
3. Rewrote the good epilogues for factions to shift the tone to more ambiguous outcomes, leaning towards "they continue to exist but the future is chaotic and uncertain" instead of ye olde standard "shit's fucked and you wasted your time"
4. Wrote a mid-tier epliogue for the Old Guard, since completing just one of the main mission chains wasn't enough to actually max it out.
5. Added a value to the faction window that prints the faction's power rating, to make this easier to test.

The Old Guard has had its epilogue ranges adjusted such that completing the mission chain of either the representative or the doctor will bump their faction power up enough to trigger the mid-tier ending. Doing the necropolis mission chain in addition to either of the first two chains will, combined, push faction power up enough to hit the good ending.

Describe alternatives you've considered

1. Also writing a high-power-value faction epilogue for "your faction" since the epilogue fix includes a power_max value for that faction, even though it doesn't define a high-power epilogue for it.
2. Also porting over Mr. Lapin's ending, will require also hunting down the PR that gives him his own faction since right now he's in the "no faction" group.
3. Futzing about with reward values, or even better expanding the necropolis, so that you can do enough stuff down there to trigger their good ending purely through Vault Boy's Wild Ride.
4. Making the faction strength number only show up if you have debug mode on? Seems fine to me, just dunno how best to phrase it in a way that both doesn't confuse players who dunno what they're looking at while still giving a useful number to players actively testing a faction's progression.

Testing

1. Checked affected JSON files for syntax and lint errors.
2. Compiled and load-tested changes.
3. Met the Old Guard rep then immediately committed sudoku, confirmed the bad end epilogue showed.
4. Repeated this but instead cheated my way through his mission chain before banishing myself to the shadow realm, confirmed the mid-level epilogue showed. Faction power rating was 116.
5. Fucked off to do the necropolis mission chain and confirmed that this was enough to bump faction power to 144, triggering the good ending on succumbing to ennui.
6. Checked affected C++ file for astyle.

So, one issue I encountered while testing is the old guard doctor's second mission is broken. I couldn't find any sign of a working console spawning in the mission target area.

Additional context

Sources:

• "Fix faction epilogues displaying incorrectly" by @MNG-cataclysm: Fix faction epilogues displaying incorrectly CleverRaven/Cataclysm-DDA#60673 (with tuning for OLd Guard's factions, sanity-checking of power required for other factions to come soonish)
• "Add Faction Endings to Hub 01" by @ghost: Add Faction Endings to Hub 01 CleverRaven/Cataclysm-DDA#48007 (scrapped their "good" ending because it manages to actively be a more grimdark ending than their genuine Bad End).
• "Add faction epilogues" by @MNG-cataclysm: Add faction epilogues  CleverRaven/Cataclysm-DDA#61305 (just the Isherwoods for now since we lack the prisoners and valhallists, and Lapin presently lacks his own faction, kept the Isherwood endings as-is since the good ending is an actual improvement over the bad ending).

I still need to hit the other factions with a similar in-depth dive to see what power ratings their missions push them to, and adjust faction epilogues accordingly. It's a start at least.

[Nguyenhuy1989]

`

[chaosvolt]

`

Uh, yes?

[thegu5]

that random comment was probably because this pr appears on the @ghost account (which takes the place of deleted accounts)

[chaosvolt]

Oh, ah right I didn't realize at the time that was a thing.

[cloudcloudskies]

lol

[metlina2]

Özet

ÖZET: İçerik "Hizip penceresine hizip gücü ekleyin, gereksiz hizip sonsözlerini düzeltin, bazı sonsözleri yeniden yazın ve Eski Muhafız sonsözlerini detaylandırın"

Değişimin amacı

Fraksiyon sonsözlerinin bozulmasına yönelik kolay bir JSON düzeltmesi olduğu ortaya çıkan şeyi aktarın. Ayrıca eksik olan gruplar için birkaç sonsöz aktarın. Ve özellikle yapmayı çok istediğim şey, "iyi" sonların yazımını ya gerçekten iyi ya da ideal olarak belirsiz kılmaktı. Minimum düzeyde "temel sondan daha kötü veya daha kötü değil"

Çözümü açıklayın

1. Hub 01 ve Isherwood'lar için grup sonsözleri aktarıldı.
2. Kötü sonun tanımlanmamış olması nedeniyle potansiyel olarak hem iyi sonu hem de kötü sonu gösteren hizip son sözlerini düzeltin power_max.
3. Eski standart "bok berbat ve sen zamanını boşa harcadın" yerine "var olmaya devam ediyorlar ama gelecek kaotik ve belirsiz" yaklaşımına yönelerek, tonu daha belirsiz sonuçlara kaydırmak için gruplar için iyi sonsözleri yeniden yazdık.
4. Eski Muhafızlar için orta seviye bir sonsöz yazdım çünkü ana görev zincirlerinden yalnızca birini tamamlamak, maksimuma çıkarmak için yeterli değildi.
5. Test etmeyi kolaylaştırmak için, fraksiyonun güç derecesini yazdıran fraksiyon penceresine bir değer eklendi.

Eski Muhafızların sonsöz aralıkları, temsilcinin veya doktorun görev zincirini tamamlayarak grup güçlerini orta kademe sonunu tetikleyecek kadar artıracak şekilde ayarlandı. İlk iki zincirden herhangi birine ek olarak Nekropolis görev zincirini yapmak, bir araya geldiğinde hizip gücünü iyi sona ulaşmaya yetecek kadar artıracaktır.

Düşündüğünüz alternatifleri açıklayın

1. Ayrıca "sizin grubunuz" için yüksek güç değerli bir grup sonsözü yazmak, çünkü sonsöz düzeltmesi, power_maxkendisi için yüksek güçlü bir sonsöz tanımlamasa da, o grup için bir değer içerir.
2. Ayrıca Bay Lapin'in sonunu ele almak, şu anda "hizip yok" grubunda olduğundan ona kendi hizipini veren PR'nin peşine düşmeyi de gerektirecek.
3. Ödül değerleriyle uğraşmak veya daha da iyisi nekropolü genişletmek, böylece orada sadece Vault Boy's Wild Ride aracılığıyla onların iyi sonunu tetiklemek için yeterince şey yapabilirsiniz.
4. Making the faction strength number only show up if you have debug mode on? Seems fine to me, just dunno how best to phrase it in a way that both doesn't confuse players who dunno what they're looking at while still giving a useful number to players actively testing a faction's progression.

Testing

1. Checked affected JSON files for syntax and lint errors.
2. Compiled and load-tested changes.
3. Met the Old Guard rep then immediately committed sudoku, confirmed the bad end epilogue showed.
4. Repeated this but instead cheated my way through his mission chain before banishing myself to the shadow realm, confirmed the mid-level epilogue showed. Faction power rating was 116.
5. Fucked off to do the necropolis mission chain and confirmed that this was enough to bump faction power to 144, triggering the good ending on succumbing to ennui.
6. Checked affected C++ file for astyle.

So, one issue I encountered while testing is the old guard doctor's second mission is broken. I couldn't find any sign of a working console spawning in the mission target area.

Additional context

Sources:

• "Fix faction epilogues displaying incorrectly" by @MNG-cataclysm: Fix faction epilogues displaying incorrectly CleverRaven/Cataclysm-DDA#60673 (with tuning for OLd Guard's factions, sanity-checking of power required for other factions to come soonish)
• "Add Faction Endings to Hub 01" by @ghost: Add Faction Endings to Hub 01 CleverRaven/Cataclysm-DDA#48007 (scrapped their "good" ending because it manages to actively be a more grimdark ending than their genuine Bad End).
• "Add faction epilogues" by @MNG-cataclysm: Add faction epilogues  CleverRaven/Cataclysm-DDA#61305 (just the Isherwoods for now since we lack the prisoners and valhallists, and Lapin presently lacks his own faction, kept the Isherwood endings as-is since the good ending is an actual improvement over the bad ending).

I still need to hit the other factions with a similar in-depth dive to see what power ratings their missions push them to, and adjust faction epilogues accordingly. It's a start at least.

[chaosvolt]

eh?

[chaosvolt]

Goofy ahh spam account