Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faction Endings to Hub 01 #48007

Merged
merged 6 commits into from Mar 16, 2021
Merged

Add Faction Endings to Hub 01 #48007

merged 6 commits into from Mar 16, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 13, 2021

Summary

Content "Add faction endings to Hub 01"

Purpose of change

Every other major faction currently implemented has a faction ending, except the Robofac, or Hub 01. This change will rectify that.

Describe the solution

Add thematically appropriate endings for Hub 01.

Describe alternatives you've considered

N/A

Testing

Put in the game. Did mission. Confirm it shows up.

Additional context

There is no way to even get a faction's power to 150, except for the Commune. I'm using @mlangsdorf 's sample epilogues posted in the CDDA development discord.

@ghost ghost requested a review from I-am-Erk as a code owner March 13, 2021 01:05
@anothersimulacrum anothersimulacrum added the [JSON] Changes (can be) made in JSON label Mar 13, 2021
@ghost
Copy link
Author

ghost commented Mar 13, 2021

@mlangsdorf just said on the discord:

My epilogues don't mention them [the Hub 01 maintenance staff] because I tossed them off in 5 minutes as a sample, not as a long considered and reviewed submission.

If anyone can give me improvements i'll be happy to add them!

Expands on faction relations and the reasons for Hub 01's downfall.

Co-authored-by: actual-nh <74678550+actual-nh@users.noreply.github.com>
@ZhilkinSerg ZhilkinSerg changed the base branch from master to 0.F-dev March 16, 2021 06:36
@ZhilkinSerg ZhilkinSerg merged commit c2565fb into CleverRaven:0.F-dev Mar 16, 2021
@ZhilkinSerg ZhilkinSerg mentioned this pull request Mar 16, 2021
14 tasks
ZhilkinSerg pushed a commit that referenced this pull request Mar 16, 2021
@ghost ghost deleted the hub_01_endings branch March 16, 2021 09:41
ZhilkinSerg pushed a commit that referenced this pull request Mar 16, 2021
ZhilkinSerg pushed a commit that referenced this pull request Mar 18, 2021
ZhilkinSerg pushed a commit that referenced this pull request Mar 18, 2021
ZhilkinSerg pushed a commit that referenced this pull request Mar 21, 2021
ZhilkinSerg pushed a commit that referenced this pull request Mar 21, 2021
John-Candlebury pushed a commit to John-Candlebury/Cataclysm-DDA that referenced this pull request Mar 24, 2021
ZhilkinSerg pushed a commit that referenced this pull request Mar 25, 2021
ZhilkinSerg pushed a commit that referenced this pull request Mar 25, 2021
ZhilkinSerg pushed a commit that referenced this pull request Mar 25, 2021
ZhilkinSerg pushed a commit that referenced this pull request Mar 26, 2021
ZhilkinSerg pushed a commit that referenced this pull request Mar 31, 2021
ZhilkinSerg pushed a commit that referenced this pull request Mar 31, 2021
ZhilkinSerg pushed a commit that referenced this pull request Mar 31, 2021
BrettDong pushed a commit that referenced this pull request Apr 5, 2021
ZhilkinSerg pushed a commit that referenced this pull request Apr 7, 2021
ZhilkinSerg pushed a commit that referenced this pull request Apr 9, 2021
ZhilkinSerg pushed a commit that referenced this pull request Apr 20, 2021
ZhilkinSerg pushed a commit that referenced this pull request Apr 20, 2021
ZhilkinSerg pushed a commit that referenced this pull request Apr 20, 2021
ZhilkinSerg pushed a commit that referenced this pull request May 28, 2021
ZhilkinSerg pushed a commit that referenced this pull request May 28, 2021
ZhilkinSerg pushed a commit that referenced this pull request May 31, 2021
ZhilkinSerg pushed a commit that referenced this pull request Jun 14, 2021
ZhilkinSerg pushed a commit that referenced this pull request Jun 14, 2021
ZhilkinSerg pushed a commit that referenced this pull request Jun 14, 2021
ZhilkinSerg pushed a commit that referenced this pull request Jun 21, 2021
ZhilkinSerg pushed a commit that referenced this pull request Jul 3, 2021
anothersimulacrum pushed a commit to anothersimulacrum/Cataclysm-DDA that referenced this pull request Jul 3, 2021
KorGgenT pushed a commit to KorGgenT/Cataclysm-DDA that referenced this pull request Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants