Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed impassable furniture stopping the player from climbing #2716

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

AniDemi
Copy link
Contributor

@AniDemi AniDemi commented Apr 27, 2023

Summary

SUMMARY: Bugfixes "Fixed impassable furniture stopping the player from climbing"

Purpose of change

During gameplay I have noticed that having too many furniture around a downspout will cause it to no longer be climbable, as far I know this is unintended behaviour. This issue should also affect everything that is climbable, with a few exceptions.

Fixes #2704

Describe the solution

Made the return unable to return anything lower than 0, makes it so that the move cost won't go negative and thus stop the player from climbing.

Describe alternatives you've considered

Do nothing, it might be intended.
Cry because I accidentally removed everything I wrote.

Testing

  1. Try to climb with 5 impassable furniture around, can climb
  2. Try to climb with 6 impassable furniture around, can now climb unlike before.

@github-actions github-actions bot added the src PR changes related to source code. label Apr 27, 2023
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Compiled and load-tested.
  2. Clambering up the evac pipe works as normal.
  3. Spawned in an ever-increasing number of road barricades to fill the surrounding empty spaces, still was able to climb each time.

@chaosvolt chaosvolt merged commit 6fea142 into cataclysmbnteam:upload Apr 28, 2023
13 of 16 checks passed
@AniDemi AniDemi deleted the climbablefix branch April 28, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src PR changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

downspout not climbable in s_garage_2
2 participants