Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate out betavoltaic item #2727

Merged
merged 1 commit into from
Apr 29, 2023
Merged

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented Apr 29, 2023

Summary

SUMMARY: Balance "Fix spawn of now-useless betavoltiac item, migrate it out"

Purpose of change

Fixes for stuff overlooked in a PR I merged, hecc: #2725

Describe the solution

  1. Added a migration converting betavolatics to plutonium cells.
  2. Set centrifuges to yield plutonium cells instead of betavolatics on deconstruct.
  3. Updated a flier snippet to not refer to any specific item now and instead just nuclear energy in general.

Describe alternatives you've considered

Screaming. More seriously, also migrating the RTG item at some point, assuming I don't find a way to use that to make plutonium generators a valid grid furniture balanced towards a low level of infinite power instead of burning plutonium cells (in which case I'd still use the minireactor for that).

Testing

  1. Checked affected files for syntax and lint errors, and searched for any other hints of the item in JSON and mods folders.
  2. Started up a save in an older release, spawning in 5 betavoltaics in my inventory and 5 on the ground.
  3. Saved and copied save folder to compiled test build in this branch.
  4. Loaded it up, obtained a total of 50 plutonium cells.

Additional context

@github-actions github-actions bot added the data PRs related to datas. Won't crash game (probably) label Apr 29, 2023
@scarf005 scarf005 self-requested a review April 29, 2023 05:23
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. could you

  1. mention PR number in purpose of change
  2. test if betavoltaic cells are correctly migrated?

@chaosvolt
Copy link
Member Author

And tested with 10 cells, each one turns into an entire stack of the default 5 cells each (with any in your inventory merging stacks, loose ones on the ground don't).

image

Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before migration After migration
Cataclysm: Bright Nights - cbn-experimental-2023-04-29-0458_02 Cataclysm: Bright Nights - cbn-experimental-2023-04-29-0458_03

1 betavoltaic cells are converted to 5 plutonium cells. i guess that's okay conversion ratio considering it's only done once and is beta cells being quite scarce.

image

deconstructing centrifuge gives intended plutonium cells.

@scarf005 scarf005 merged commit 92b7393 into cataclysmbnteam:upload Apr 29, 2023
14 checks passed
@chaosvolt chaosvolt deleted the i-am-screm branch April 29, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data PRs related to datas. Won't crash game (probably)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants