Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External tileset updates and documentation #2886

Merged

Conversation

chaosvolt
Copy link
Member

Summary

SUMMARY: Interface "Fix an incorrect ID in external tileset, add a few more sprites and documentation tracking additions"

Purpose of change

This fixes a mistake I made last update with the external tileset, adds support for two new weapons previously added, and adds a document laying out the reason behind the external_tileset folder and an overview of all things covered by its sprites.

Describe the solution

  1. Fixed sprite overrides for composite greatbow citing wrong item ID.
  2. Added sprites for katar and sai.
  3. Added documentation, which covers all content currently warranting a new or overriding sprite.

Describe alternatives you've considered

Putting documentation file in the doc folder instead. Main issue with that is this helps make it easier to remember to update the listed changes in said file.

Testing

  1. Checked affected tile config for syntax and lint errors.
  2. Loaded up in compiled test build, composite greatbow doesn't look like a compound bow in UDP, sai and katar have sprites.

Additional context

@github-actions github-actions bot added the JSON related to game datas in JSON format. label May 26, 2023
@scarf005 scarf005 self-assigned this May 27, 2023
scarf005
scarf005 previously approved these changes May 29, 2023
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know it's ton of work but could you also link relevent PRs to specific to BN?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I could, gimme a bit then.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And implemented.

@scarf005 scarf005 merged commit 2eb3f97 into cataclysmbnteam:upload May 30, 2023
@chaosvolt chaosvolt deleted the more-external-tileset-stuff branch May 30, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants