Fix Killer Drive trait not liking murder, not prompting on cannibalism #2889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Killer Drive now rewards for killing innocent NPCs, prompts before committing cannibalism"
Purpose of change
One annoyance I found was that Killer Drive clashed with the Psychopath trait, motivating you to kill but still prompting guilt when you kill an innocent NPC. It also had the flaw where the
CANNIBAL
trait flag would mark human flesh as safe to eat and fail to prompt you, but because the morale effect only looks for the Cannibal trait itself, you'd end up getting sad about it.Describe the solution
C++ changes:
JSON changes:
PSYCHOPATH
trait flag. Its effects are buried in the code largely unused, but the key thing is it counts as identical to Cannibal and Sapiovore for the purpose of butchering human corpses, without flagging human flesh as being safe to eat (when it secretly isn't in the case of Killer Drive).Describe alternatives you've considered
If we increased the overlap between Psychopath and Killer Drive, since it comes with morale for doing what the average Cata player will be doing by the dozen anyway, we're likely want to bump the point cost of Killer Drive up a bit. In its current form as of this PR, you get all of the murder-related benefits of Psychopath and have the option to spend an extra point to get a morale-increasing equivalent to the people-eating benefits, leaving only gravedigging absent.
Testing
Additional context
The discovery of the
PSYCHOPATH
flag also gives me something I can use for Arcana, to allow sanguinist professions to always be okay with butchering corpses.