Changes to JSON data for consistency #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leave temporary support for `ident`. Marked with: // TEMPORARY until 0.G: Remove "ident" support
Previously we whitelisted "//" and "comment" as keys which were allowed to be duplicated in json objects. Stop doing that. Allowing these duplicate keys only causes problems when attempting to process the game data files using other json tools or libraries.
chaosvolt
added a commit
to chaosvolt/cdda-arcana-mod
that referenced
this pull request
Feb 22, 2021
Now that id is valid for these JSON types thanks to cataclysmbnteam/Cataclysm-BN#324 that allows me to update the BN version of Arcana accordingly. Other mod updates to follow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
Make JSON data more consistent.
Describe the solution
idinstead ofidentfor identifier member names (see CleverRaven#39332 )Code related commits were cherry-picked, the rest is automatic refactoring.
Describe alternatives you've considered
Remove support for
identand lone top level objects right here right now, but I'm pretty sure modders wouldn't like that.Testing
Tests pass, the game loads a save.
Additional context
In case someone will need them: py-scripts.tar.gz