chore!: migrate legacy unit #3312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
JSON
olanti-p
reviewed
Sep 29, 2023
scarf005
force-pushed
the
migrate-legacy-unit
branch
from
292aafe
to
c145e2a
Compare
github-actions
bot
added
mods
|
Tests failed, it's related. |
I've found out many fields have different meanings depending on its types, for example tests fail due to the script converting |
scarf005
force-pushed
the
migrate-legacy-unit
branch
from
c145e2a
to
d2f2ec8
Compare
scarf005
force-pushed
the
migrate-legacy-unit
branch
3 times, most recently
from
1b5ef6d
to
3e01158
Compare
scarf005
force-pushed
the
migrate-legacy-unit
branch
from
3e01158
to
801d4f4
Compare
scarf005
force-pushed
the
migrate-legacy-unit
branch
from
801d4f4
to
f6301b7
Compare
due javascript having no distinction between int and float, parsing and saving 1.0 will not be idempotent. thus we rewrite all instances of 'integer floats' into actual integers.
scarf005
force-pushed
the
migrate-legacy-unit
branch
from
42cc3e7
to
4c1e0da
Compare
|
failures are unrelated (wearing power armor) |
|
The power armor test fail is weird since it seems to be complaining about an item combo the player can spawn in and wear just fine... |
joveeater
approved these changes
Dec 2, 2023
Merged
via the queue into
cataclysmbnteam:upload
with commit Dec 2, 2023
2703a29
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
Describe the solution
Wrote a migration script. It preserves object field order, making it idempotent. It will convert:
for convenience,
deno task migrate-unitwilldata/jsonanddata/mods.Describe alternatives you've considered
autofix.ci? while the script is fairly inefficient, it only takes at most ~2 seconds to replace (without formatting).Testing
Was able to load previous save without errors