Set application name to Cataclysm BN on OSX #3502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olanti-p
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Build "Set application name to Cataclysm BN on OSX"
Purpose of change
As described in #3501, having the same application name as CDDA causes problems for some interactions on OSX when you have both installed.
Fixes #3501
Describe the solution
It's just a static metadata change
Describe alternatives you've considered
It's possible the bundle name should change, but I'm not sure, so I left it
This will cause save data to become located at
~/Library/Application Support/Cataclysm BNinstead of..../Cataclysm. This means that after this is released, OSX users will need tomvtheir old save files or rename them in Finder.As a side benefit, this means that CDDA save data and BN save data are now in separate locations