Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): house_fence02 #3574

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

LilShiningMan
Copy link
Contributor

Summary

SUMMARY: CONTENT "house_fence02"

Purpose of change

more houses

Describe the solution

Describe alternatives you've considered

Testing

linted and spawned in game

Additional context

house_fence02_1

house_fence02_2

house_fence02_roof

Checklist

If this is a C++ PR that modifies JSON loading or behavior:

  • Document the changes in the appropriate location in the doc/ folder.
  • If documentation for this feature does not exist, please write it or at least note its lack in PR description.
  • New localizable fields need to be added to the lang/bn_extract_json_strings.sh script if it does not support them yet.
  • If applicable, add checks on game load that would validate the loaded data.
  • If it modifies format of save files, please add migration from the old format.

If this is a PR that modifies build process or code organization:

  • Please document the changes in the appropriate location in the doc/ folder.
  • If documentation for this feature or process does not exist, please write it.
  • If the change alters versions of software required to build or work with the game, please document it.

If this is a PR that removes JSON entities:

  • The removed JSON entities have new entries in data/json/obsoletion/ folder.

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Nov 5, 2023
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

those multi-floor houses are really great. LGTM

@chaosvolt chaosvolt added this pull request to the merge queue Nov 6, 2023
Merged via the queue into cataclysmbnteam:upload with commit b8dfae5 Nov 6, 2023
14 checks passed
@LilShiningMan LilShiningMan deleted the house_fence02 branch November 6, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants