-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(content): Roman Revival #3603
Conversation
Modified existing medieval armor that one could reasonably learn to craft on their own to be autolearn, as well as added in armored skirts and sandals to complement the lorica segmentata.
Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
But then I gotta add brackets to another area so guess I'm feeding the `components` section those brackets like it's a baby bird.
Okay, everything else looks good, interesting even, though possibly the cloth skirt might be a tad redundant given it's flavored as being less protective than a gambeson, and it's a massive downgrade over the leather pteruges for not really much easier material cost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost forget we oughta be doing this.
Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
@yay855 applied suggestions made by @chaosvolt as the PR seemed inactive. please ping if the changes don't look good. merging as local tests passed. |
Summary
SUMMARY: Content "Modifies existing simple medieval armor to be automatically craftable and adds in new armored skirts and sandals."
Purpose of change
Prior to this PR, there were several types of medieval armor which a player could reasonably craft on their own initiative without having an external diagram or guide, but which were not autolearn. The full Roman soldier armor set was also missing its skirt and sandals.
Describe the solution
Leather lamellar armor and lorica segmentata are now autolearn, since they're both simply layered strips of armor (leather or steel) sewn together.
Similarly, boiled leather armor is also now autolearn, since it was a less-effective variation of plated leather armor which WAS autolearn; boiled leather armor has also had its thickness increased to match plated leather armor to better reflect its improved protective values from the boiling process, and because plated leather armor is superior to it in every way regardless save for two points of encumbrance.
I have also added in armored leather sandals and three different armored leather skirts, one cotton, one leather, and one plated leather, all to complement the lorica segmentata.
Describe alternatives you've considered
The leather lamellar armor is frankly rather redundant given that we already have other forms of leather armor which serve the purpose just as well, and the boiled leather armor is also redundant given plated leather armor. It may be worthwhile to obsolete those items to make for less clutter.
Testing
The json checks out, and the balance seems right to me.