fix: Dropping wielded count-by-charges items causing errors
#3628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
src
scarf005
changed the title
scarf005
changed the title
count-by-charges items causes errors
scarf005
changed the title
count-by-charges items causes errorscount-by-charges items causing errors
scarf005
approved these changes
Nov 11, 2023
Merged
via the queue into
cataclysmbnteam:upload
with commit Nov 11, 2023
a284394
14 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fixed error dropping wielded count-by-charges items"
Purpose of change
Fixes #3606.
Describe the solution
Removed character::i_rem(item*). This function is a bit awkward and slow, doesn't work right with cbc items and can be easily replaced with item->detach().