feat(content): bungalow 26

[LilShiningMan]

Summary

SUMMARY: CONTENT "bungalow 26"

Purpose of change

more houses

Describe the solution

Describe alternatives you've considered

Testing

linted and tested in game

Additional context

This might be a pain to review, but there's 2 basement variants and 3 ground floor variants

Checklist

If this is a C++ PR that modifies JSON loading or behavior:

• Document the changes in the appropriate location in the doc/ folder.
• If documentation for this feature does not exist, please write it or at least note its lack in PR description.
• New localizable fields need to be added to the lang/bn_extract_json_strings.sh script if it does not support them yet.
• If applicable, add checks on game load that would validate the loaded data.
• If it modifies format of save files, please add migration from the old format.

If this is a PR that modifies build process or code organization:

• Please document the changes in the appropriate location in the doc/ folder.
• If documentation for this feature or process does not exist, please write it.
• If the change alters versions of software required to build or work with the game, please document it.

If this is a PR that removes JSON entities:

• The removed JSON entities have new entries in data/json/obsoletion/ folder.

[chaosvolt]

Aw yiss, mapgen variations. :D

[scarf005]

[chaosvolt]

What terrain/furniture are the ]s in this supposed to be? Seems to be the cause of the error.

[LilShiningMan]

Ooops, this is really old house that I updated with the new palette and it appears that I missed taking those out. Strange that it didn't give me an error. Those should actually just be taken out. I can do that now

…

On Sun, Nov 12, 2023 at 5:07 PM Chaosvolt ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In data/json/mapgen/house/bungalow26.json <#3650 (comment)> : > + "object": { + "palettes": [ "standard_domestic_palette", "standard_domestic_lino_bathroom", "standard_domestic_landscaping_palette" ], + "fill_ter": "t_floor", + "rows": [ + ".###_______©-----------.", + ".#__________-----------.", + ".#_________0-----------.", + ".#(________0-----------.", + ".#(_________-----------.", + ".#)________0-----------.", + ".#############%-###oo##.", + ".# |B£t| o%-# #.", + ".# |B£}|zzz o%-# o.", + ".# |££=|zzz #o*# o.", + ".#|+||+||||| |z |zz #.", + ".o> ] + |z |||+||#.", What terrain/furniture are the ]s in this supposed to be? Seems to be the cause of the error. — Reply to this email directly, view it on GitHub <#3650 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANRGAGBZ5UZ3L6LBE74GPE3YEFXFXAVCNFSM6AAAAAA7IJI246VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMRWGQYTAOJUG4> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>