Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): update capacity of power armor holsters #3733

Merged

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented Nov 21, 2023

Purpose of change

Updates some items I overlooked back when I updated holster sizes in #3159, plus expand on one item's role.

Describe the solution

  1. Per Scarf's suggestion, increased max volume of back holster from 9 liters to 10 liters, matching that of power armor back holster.
  2. Increased maximum volume of power armor holster from 800 ml to 1 liter and minimum volume from 100 ml to 250 ml, matching standard holster.
  3. Altered the power armor chest rig a bit, renaming it to "power armor magazine carrier" to distinguish it from from the carry stats of the standard chest rig. Reduced its max mags down to only 2, but bumped its max volume to 1500 ml and allowed it to hold items with the MAG_BULKY flag. This gives it the ability to stash spare heavy batteries, like what a UPS loads.

Describe alternatives you've considered

  1. Allowing the mag pouches to also hold ammo belts via adding a flag to it. 5.56 and 7.62 have a pretty massive volume when maxed out at 500 rounds, and even if toned down to 200 that'd require the mag carrier's capacity to be boosted a bit higher, while it'd hold a 200-round 5.56mm belt a 200-round 7.62mm belt is still just a hair over 2.5 liters.
  2. Allowing more mag carrier items to hold MAG_BULKY items.

Testing

Checked affected file for syntax and lint errors.

Additional context

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Nov 21, 2023
@scarf005
Copy link
Member

i think increasing volume of both back holster to 10L might be a bit better.

@chaosvolt
Copy link
Member Author

Sure, will do. :>

Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'll be OK to allow three mags tho

@scarf005 scarf005 added this pull request to the merge queue Nov 22, 2023
Merged via the queue into cataclysmbnteam:upload with commit 05c0d82 Nov 22, 2023
11 of 12 checks passed
@chaosvolt chaosvolt deleted the forgot-that-there-are-holsters-here branch November 22, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants