Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix naming conventions for mag pouches, remove redundant plural #3788

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

chaosvolt
Copy link
Member

Purpose of change

Fixes some assorted things I overlooked when approving #3777

Describe the solution

  1. Removes redundant, misspelled plural form of the renamed ammo satchel.
  2. Renamed ammo pouches/satchels to refer to magazines instead. Turns out someone (someones, both @yay855 who PR'd it and me who approved it) forgot that "ammo satchel" was already in use for the name of the makeshift waist mag carrier, so might as well just standardize that now.

Describe alternatives you've considered

  1. Reverting the ammo pouch name change in above PR.
  2. Screaming.

Testing

  1. Checked affected file for syntax and lint errors.
  2. Used my eyes for once.

Additional context

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Nov 30, 2023
@chaosvolt chaosvolt changed the title fix(bugfixes): fix naming conventions for mag pouches, remove redundant plural fix: fix naming conventions for mag pouches, remove redundant plural Nov 30, 2023
@scarf005 scarf005 added this pull request to the merge queue Nov 30, 2023
Merged via the queue into cataclysmbnteam:upload with commit ca6e177 Dec 1, 2023
12 checks passed
@chaosvolt chaosvolt deleted the i-am-full-of-scream branch December 1, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants