fix: clang-tidy CI failure #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unsure whether it's true positive or false positive.
scarf005
force-pushed
the
fix-clang-tidy
branch
from
03d524f
to
92d9395
Compare
scarf005
commented
Dec 7, 2023
| @@ -1437,6 +1437,7 @@ item &location_inventory::add_item_by_items_type_cache( detached_ptr<item> &&new | |||
| if( should_stack ) { | |||
| for( auto &elem : inv.items ) { | |||
| item *&it = *elem.begin(); | |||
| // NOLINTNEXTLINE(bugprone-use-after-move) | |||
| if( it->stacks_with( *newit ) ) { | |||
There was a problem hiding this comment.
@joveeater could you check whether this warning is false positive or not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
fix clang-tidy CI failures happening for weeks.
Describe the solution
fix errors pointed by clang-tidy
Describe alternatives you've considered
RIIR
Testing
tests pass locally.