Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): 2storymodern05 house #4080

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

LilShiningMan
Copy link
Contributor

@LilShiningMan LilShiningMan commented Jan 9, 2024

add 2storymodern05

Purpose of change

more houses

Describe the solution

Describe alternatives you've considered

Testing

linted and spawned in game

Additional context

2StoryModern05-b
2StoryModern05-g
2StoryModern05-2
2StoryModern05-r

I also changed the spawn rate of 2storymodern01 -- not sure why I originally had this really low, though it might have been a typo in the original version. I've bumped it up to 50 like all other houses.

Checklist

add 2storymodern05
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Jan 9, 2024
Copy link
Contributor

autofix-ci bot commented Jan 9, 2024

The Autofix app has found code style violation and automatically formatted this Pull Request.

I locally edit my commits (e.g: git, github desktop)

Please choose following options:

I'd like to accept the automated commit
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

This PR is complete and I don't want to edit it anymore

It's safe to ignore this message.

I edit this PR through web UI

You can ignore this message and continue working.

I have no idea what this message is talking about

You can ignore this message and continue working. If you find any problem, please ask for help and ping @scarf005.

Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Something tells me that the domestic palette is starting to get progressively more and more wacky with how many characters it needs to define... ¤_¤

@scarf005 scarf005 changed the title feat(content): 2storymodern05 feat(content): 2storymodern05 house Jan 9, 2024
@scarf005 scarf005 merged commit 75dd83f into cataclysmbnteam:main Jan 9, 2024
9 checks passed
@LilShiningMan
Copy link
Contributor Author

Ah, it's a way of future-proofing these a little bit. I figure if people add things to the palette they're likely going to use more common symbols. With a more obscure symbol there's less potential of having weird overwriting item spawns as the standard palette evolves.

@LilShiningMan LilShiningMan deleted the 2storymodern05 branch January 11, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants