fix: switch build tool back to v142 to fix vs2019 #4159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarf005
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
So it turns out #4154 also came with a bonus changing of default vcpkg settings such that VS2019 users can't compile anymore.
Describe the solution
Reverted the file changes specifically in the
msvc-full-featuresfolder.Describe alternatives you've considered
Saying "fuck you" to people who still use VS2019 (like myself) instead of expecting VS2022 users to figure out however you set it to use v143 build tools for compile-tests without changing the setting in the repo itself.
Testing
Compiled and load-tested after the revert.
Additional context
Checklist