Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): make matchhead powder recipe more granular, related fixes for mortar and pestle recipes #4271

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented Feb 29, 2024

Purpose of change

This implements some tweaks to how match head powder is make to make it less clunky to use, along with some related changes to some other mortar and pestle recipes once I noticed that a few of the recipes to use mortar and pestle lack batch time savings when most have it.

Describe the solution

  1. Set match head powder recipe to make 1 charge at a time, per 1 matchbook charge consumed. This makes it more granular, though more efficient as a side effect. Given match head powder isn't used for much besides primers (and are used en masse in that case) I feel it's not too wacky balance-wise. Time taken also reduced from 8 minutes to 1 minute, and to compensate for this increase in time per unit made it now uses the same batch time factor most other mortar and pestle recipes use.
  2. Misc: Gave the ammonium nitrate and sulfur grinding recipes batch time multipliers too. Again used the same scaling nearly all recipes involving mortar and pestle use.

Describe alternatives you've considered

Chitin meal is literally the only mortar and pestle recipe to use a time factor of 83-3 instead of 50-3, we could tweak that.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Ported JSON changes to test build, confirmed I make match head powder 1 unit at a time now and for 1 charge of matchbook each.

Additional context

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Feb 29, 2024
@chaosvolt
Copy link
Member Author

Side note: making the recipes for primers more granular would be nice too, but those have the issue of using cans, scrap metal, and the like. Unless we restrict them to only copper there's no easy way to make them more granular (and this would double the material usage too).

@scarf005 scarf005 changed the title feat(balance): make matchhead powder recipe more granular, related fi… feat(balance): make matchhead powder recipe more granular, related fixes for mortar and pestle recipes Mar 1, 2024
@scarf005 scarf005 merged commit 6d088c8 into cataclysmbnteam:main Mar 1, 2024
10 checks passed
@chaosvolt chaosvolt deleted the match-head-update branch March 1, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants