Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): residential personal items #4312

Merged
merged 4 commits into from
Mar 9, 2024

Conversation

LilShiningMan
Copy link
Contributor

Purpose of change

Houses get to feeling sort of cookie cutter and uniform after a while, with the same general palette used all the time. I wanted to add a nested chunk to the palette that could generate a random, somewhat unique set of items/furniture to break up the monotony a little bit. Hopefully this will hint at the lives of the people who lived in these houses, even if its just in the form of some random clothing or hobby items, etc.

If nothing else, it'll be another way to maybe get some specialty items outside of raiding specific kinds of stores, add a bit of environmental story-telling, or maybe just make people pause for a second and scratch their heads.

Describe the solution

Add a nested container that is only 1X1 tiles big, used to spawn nested chunks in houses. Added a few variants that are called by the nested container, which is what is called in each house file. Adding to the nested container is a way of globally adding new variants or controlling the spawn ratios without needing to edit each individual house file.

Describe alternatives you've considered

Doing nothing and letting houses remain sort of dull.

Testing

linted and spawned in game.

Additional context

Since the container chunk is so small, nested chunks shouldn't be full setups (ie- a woodworking table), but rather a small collection of items or perhaps a small piece of furniture that is of interest to one specific person, that can be found either in a closet or a corner of a bedroom.

There are only 2 variants to start, to make this easier to review, but I plan on adding many more in the future, and hopefully other people will as well.

Electric guitar, amp and patch cords -- generated in a 1X1 chunk, but I guess because there is no room on the tile, the guitar spills out into an adjoining tile, which I think works well
chunk - guitar

Scuba diving equipment in a box, like an amateur diver might have tucked away in a closet
chunk - scuba

Checklist

add nested container for unique personal items to spawn in houses
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Mar 8, 2024
@scarf005 scarf005 changed the title content (feat): residential personal items feat(content): residential personal items Mar 8, 2024
@LilShiningMan
Copy link
Contributor Author

sorry, reversed the pr title format there

LilShiningMan and others added 2 commits March 8, 2024 12:19
Why is there not just not one full override of `standard_domestic_palette` in No Hope but TWO of them!?
@github-actions github-actions bot added the mods PR changes related to mods. label Mar 9, 2024
@chaosvolt
Copy link
Member

And there we go, that should cover it unless we missed anything. If VS2019 hadn't decided its machine spirit was going to wake up and choose violence today, or if I had noticed sooner that I can check out people's PRs in github desktop, this would've been absolutely trivial for me to fix.

Either way the actual work of fixing No Hope (again) was vastly dwarfed by even the most streamlined of all possible ways to check our your branch to fix it myself.

Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR!

image

local tests passed, let's merge when CI tests too pass.
also, @LilShiningMan have you joined our official dev server?

@scarf005 scarf005 merged commit 59eb28f into cataclysmbnteam:main Mar 9, 2024
10 checks passed
@LilShiningMan LilShiningMan deleted the res_personal_items branch June 14, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants