Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): add vehiclepart raincatcher #4511

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

chaosvolt
Copy link
Member

Purpose of change

This adds the option to use tarp raincatchers on vehicles, the only other vanilla funnel option besides gutters (which aren't exactly portable) to not have a vehiclepart option.

Describe the solution

  1. Added a vehiclepart version of tarp raincatcher. Since collection power is all in liters, used 90 instead of the jank-ass volume value the trap version used.
  2. But for consistency, bumped the value the trap version can handle from 85.5 liters to 90 liters.

Describe alternatives you've considered

Mainlining leather tarp raincatchers from MST Extra too.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Load-tested and set up two raincatchers over 60-liter tanks, one in trap form and the other a vehiclepart over an installed tank.
  3. Waited...motherfucking FOREVER to finally get weather that's fucking rainy.
  4. Gave up and loaded back in after temporarily editing base humidity to be higher in regional map settings because blyaaat.
  5. Loaded in, found it was raining now, waited it out. The tank under the trap version had 6 units of water in it, the vehicle version only had 5.
  6. Re-loaded and waited out the rain a second time, different was now 14 vs 9 units.

Given this, I'm convinced there is some fuckery going on, either randomization that needs some good solid testing, or else vehicle funnels are busted.

Additional context

Related issue: #4488

Until I do more testing I don't want to say this actually fixes that issue. Metal funnels are already still better than tarp raincatchers, so lacking tarp raincatchers doesn't seem like it'd be a magic bullet that'd fix things. Not unless the player in question just never bothered to test metal funnels on vehicles, presumably because they're a pain in the dick and have to be welded on to install, but I'd really want to test this more in case there's some hidden code fuckery going on too.

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Apr 22, 2024
@VissValdyr
Copy link
Contributor

This reminds me. Rain is super rare. Maybe bumping it up makes sense?

Also humidity water collectors, with extra moldy smell for taste.

I wonder if we can use satellite dishes for rain collectors too, it's not like we want to watch the shopping channel rerolls all day.

@chaosvolt
Copy link
Member Author

This reminds me. Rain is super rare. Maybe bumping it up makes sense?

If we can't get rain to behave sanely with current settings them maybe we should, yeah.

@VissValdyr
Copy link
Contributor

Another finished one. Nice

@scarf005 scarf005 merged commit 7384db7 into cataclysmbnteam:main Apr 27, 2024
10 checks passed
@chaosvolt chaosvolt deleted the funnels-go-nyoom branch April 27, 2024 16:12
@Unrepentant-Atheist
Copy link

Unrepentant-Atheist commented Apr 29, 2024

Is gud shite! Is very gud shite!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants