feat(content): add vehiclepart raincatcher #4511
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
This adds the option to use tarp raincatchers on vehicles, the only other vanilla funnel option besides gutters (which aren't exactly portable) to not have a vehiclepart option.
Describe the solution
Describe alternatives you've considered
Mainlining leather tarp raincatchers from MST Extra too.
Testing
Given this, I'm convinced there is some fuckery going on, either randomization that needs some good solid testing, or else vehicle funnels are busted.
Additional context
Related issue: #4488
Until I do more testing I don't want to say this actually fixes that issue. Metal funnels are already still better than tarp raincatchers, so lacking tarp raincatchers doesn't seem like it'd be a magic bullet that'd fix things. Not unless the player in question just never bothered to test metal funnels on vehicles, presumably because they're a pain in the dick and have to be welded on to install, but I'd really want to test this more in case there's some hidden code fuckery going on too.
Checklist