Add a static table of political subdivision attributes. #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidates several dictionaries and enumerations that we had scattered across the codebase into a single static table, with information about states, territories, provinces, etc. Including membership in various geographic aggregations, FIPS codes, etc. In the process, also added a new `ownership_country` column to the `ownership_eia860` table, to clearly differentiate between country and political subdivision information, which was comingled in the state column previously. Closes #1958
Codecov ReportBase: 82.5% // Head: 82.4% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #1966 +/- ##
=======================================
- Coverage 82.5% 82.4% -0.2%
=======================================
Files 64 64
Lines 7086 7092 +6
=======================================
- Hits 5852 5849 -3
- Misses 1234 1243 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
10 tasks
zaneselvans
added
eia860
zaneselvans
commented
Oct 3, 2022
src/pudl/metadata/enums.py
Outdated
Comment on lines
29
to
32
| STATE_TO_CENSUS_DIVISION: dict[str, str] = { | ||
| x.subdivision_code: x.division_code_us_census | ||
| for x in POLITICAL_SUBDIVISIONS.itertuples() | ||
| } |
There was a problem hiding this comment.
@TrentonBush this is the state to census division (smaller area than census region in the Census nomenclature, even though EIA seems to be calling the census divisions census regions?) that I think you need.
TrentonBush
requested changes
Oct 4, 2022
TrentonBush
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidates several dictionaries and enumerations that we had scattered across the codebase into a single static table, with information about states, territories, provinces, etc. Including membership in various geographic aggregations, FIPS codes, etc.
In the process, also added a new
ownership_countrycolumn to theownership_eia860table, to clearly differentiate between country and political subdivision information, which was comingled in the state column previously.Closes #1958