-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallelize Dagster processing of EPA CEMS #2472
Merged
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
661ff17
Convert cems to use dagster partitions
zschira 6e4e63e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d80e7c6
Create dynamic graph for epacems asset
zschira 6eb0ee5
Add partition option back to epacems asset
zschira adf2d92
Fix epacems integration tests
zschira 37609e2
Add synchronization around parquet write_table
zschira f90b3df
Seperate epacems monolithic output into its own asset to avoid synchr…
zschira 2d9e926
Create monolithic epacems parquet output from reading partitioned out…
zschira a30f031
Fix epacems unit test
zschira 887ee74
Remove partition options from cli commands
zschira d0fc821
Merge branch 'dev' into epacems_partitions
zaneselvans 150e303
Remove EPA CEMS partitioning config from tests
zaneselvans 75bac25
Add detailed module description to epacems_assets.py
zschira a3a8192
Merge branch 'epacems_partitions' of github.com:catalyst-cooperative/…
zschira 68b5116
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e3185bb
Merge branch 'dev' into epacems_partitions
zschira 61ce3c1
Reformat epacems_assets docstring
zschira 25138da
Reformat links in epacems_assets docstring
zschira File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth preserving the ability to write out a single monolithic file directly, rather than compiling it after the fact from partitioned outputs? Once the data is in Parquet, it's extremely fast to read and write and it seems simpler to avoid the issue of concurrency altogether. We're hacking around it with SQLite because we don't have a choice unless we want to switch to another format for the DB entirely, but Parquet is designed to be sliced and diced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now I don't think there's any way to directly write to the monolithic output. I was using this class for testing, but it's removed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack! This was a "pending" comment that never got submitted from 4 days ago when I first saw you push to the branch.