Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3313 Q4 2023 eia860 update #3367

Merged
merged 4 commits into from Feb 7, 2024
Merged

3313 Q4 2023 eia860 update #3367

merged 4 commits into from Feb 7, 2024

Conversation

aesharpe
Copy link
Member

@aesharpe aesharpe commented Feb 6, 2024 •
edited

Overview

Closes #3313

Adds monthly data for EIA860 up through December 2023

Testing

To-do list

Edit tasklist title
Beta Give feedback Tasklist To-do list, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure full ETL runs & make pytest-integration-full passes locally
    Options
  2. For major data coverage & analysis changes, run data validation tests
    Options
  3. If updating analyses or data processing functions: make sure to update or write data validation tests
    Options
  4. Update the release notes: reference the PR and related issues.
    Options
  5. Review the PR yourself and call out any questions or issues you have
    Options

@aesharpe
Add quarterly update for EIA860m data
606750a 
* Update file maps

* Add new plant and utility ids

* Update working paritions / DOI
@aesharpe
Merge branch 'main' into 3313-q4-23-eia860-update
fadc7cc
@aesharpe aesharpe added eia860 Anything having to do with EIA Form 860 new-data Requests for integration of new data. rmi labels Feb 6, 2024
@aesharpe aesharpe self-assigned this Feb 6, 2024
@aesharpe aesharpe marked this pull request as ready for review February 6, 2024 21:07
e-belfer
e-belfer requested changes Feb 7, 2024
View reviewed changes
Copy link
Member

@e-belfer e-belfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One blocking comment re the release notes, and two questions.

docs/release_notes.rst Outdated Show resolved Hide resolved
migrations/versions/edeebfad2670_add_q4_2023_eia860m_data.py Outdated Show resolved Hide resolved
src/pudl/package_data/glue/pudl_id_mapping.xlsx Outdated Show resolved Hide resolved
src/pudl/package_data/glue/utility_id_pudl.csv Show resolved Hide resolved
@aesharpe
Address PR comments for (#3367)
61b9e61 
* Make new section in release notes and move EIA860m quarterly update notification from old release notes to new release notes.

* Re-add plant_id_pudl values to mapping spreadsheet to investigate file size change. Still seems to be smaller than previous version of file which doesn’t make sense. But nothing was deleted.

* Remove duplicates from utility_id_pudl spreadsheet due to accidental double pasting.

* Remove unnecessary migration verison file
e-belfer
e-belfer approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@e-belfer e-belfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aesharpe aesharpe added this pull request to the merge queue Feb 7, 2024
@zaneselvans zaneselvans changed the title 3313 q4 23 eia860 update 3313 Q4 2023 eia860 update Feb 7, 2024
Merged via the queue into main with commit 198f6bb Feb 7, 2024
15 checks passed
@aesharpe aesharpe deleted the 3313-q4-23-eia860-update branch February 7, 2024 21:57
@aesharpe aesharpe mentioned this pull request Feb 9, 2024
Merged
@aesharpe
Copy link
Member Author

aesharpe commented Feb 9, 2024

Update expected row counts here #3380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-belfer e-belfer e-belfer approved these changes

@cmgosnell cmgosnell Awaiting requested review from cmgosnell

Assignees

@aesharpe aesharpe

Labels
eia860 Anything having to do with EIA Form 860 new-data Requests for integration of new data. rmi
Projects
Catalyst Megaproject
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Q4-2023 Updates to EIA860 Data
2 participants
@aesharpe @e-belfer