Update expected row count for EIA tables post 860m quarterly update #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-belfer
approved these changes
Feb 9, 2024
cmgosnell
reviewed
Feb 9, 2024
| ("bf_eia923", 1_569_568, 1_569_568, 128_252), | ||
| ("bf_eia923", 1_607_752, 1_607_752, 128_252), |
There was a problem hiding this comment.
i went and quickly looked at the build logs and it looks like this one is a typo and should be 1_670_752
E ValueError: bf_eia923: found 1607752 rows, expected 1569568. Off by 2.433%, allowed margin of 0.000%There was a problem hiding this comment.
In the example above the found value 1607752 is the same as the one I have written, it's just confusing to look at with the underscores!
e-belfer
changed the title
e-belfer
dismissed
cmgosnell’s stale review
See above, confirmed that row counts are correct
cmgosnell
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to update expected rows in validation tests as part of #3313 and #3367