New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recsys losses #1269
Recsys losses #1269
Conversation
Hello @sergunya17! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-08-09 22:13:19 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few questions here:
- do we really need
Pointwise
,PairwiseLoss
andListWiseLoss
abstractions? - could you please add usage examples for each implemented criterion? I hope, it would be much easier to understand them in this way :)
This pull request is now in conflicts. @sergunya17, could you fix it? 🙏 |
Before submitting (checklist)
catalyst-make-codestyle && catalyst-check-codestyle
(pip install -U catalyst-codestyle
).make check-docs
?pytest .
?latest
andminimal
requirements?Description
Added losses:
Based on #1253, #1255
Type of Change