Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recsys losses #1269

Merged
merged 22 commits into from Aug 10, 2021
Merged

Recsys losses #1269

merged 22 commits into from Aug 10, 2021

Conversation

sergunya17
Copy link
Contributor

@sergunya17 sergunya17 commented Aug 2, 2021

Before submitting (checklist)

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
  • Did you make sure to update the docs? We use Google format for all the methods and classes.
  • Did you check the docs with make check-docs?
  • Did you write any new necessary tests?
  • Did you check that your code passes the unit tests pytest . ?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?
  • Did you run colab minimal CI/CD with latest and minimal requirements?

Description

Added losses:

  • AdaptiveHingeLoss
  • BPRLoss
  • HingeLoss
  • LogisticLoss
  • WARPLoss

Based on #1253, #1255

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@pep8speaks
Copy link

pep8speaks commented Aug 2, 2021

Hello @sergunya17! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-08-09 22:13:19 UTC

@Scitator Scitator marked this pull request as ready for review August 9, 2021 05:55
Copy link
Member

@Scitator Scitator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few questions here:

  1. do we really need Pointwise, PairwiseLoss and ListWiseLoss abstractions?
  2. could you please add usage examples for each implemented criterion? I hope, it would be much easier to understand them in this way :)

catalyst/contrib/nn/criterion/recsys.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/criterion/recsys.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/criterion/recsys.py Outdated Show resolved Hide resolved
@mergify
Copy link

mergify bot commented Aug 9, 2021

This pull request is now in conflicts. @sergunya17, could you fix it? 🙏

@sergunya17 sergunya17 changed the title Draft: More recsys losses with tests Recsys losses Aug 9, 2021
@Scitator Scitator merged commit 37e6c25 into catalyst-team:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants