-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix topk metrics #1330
Fix topk metrics #1330
Conversation
Hello @sergunya17! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-10-19 19:49:32 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please add docs on metric logic under self.batch/epoch metrics
? For example, when you specify AccuracyCallback, it would add accuracy01
to the metrics storages
Pull request has been modified.
🤔 we also need to add a new metric to |
Recent catalyst versions changed the default formatting of the metrics, based on topk argument: catalyst-team/catalyst#1330 Close #184
Recent catalyst versions changed the default formatting of the metrics, based on topk argument: catalyst-team/catalyst#1330 Close #184
Pull Request FAQ
Description
Related Issue
Type of Change
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Checklist
latest
andminimal
requirements?