Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catalyst: Test for last version is broken #184

Closed
daavoo opened this issue Nov 3, 2021 · 0 comments · Fixed by #185
Closed

catalyst: Test for last version is broken #184

daavoo opened this issue Nov 3, 2021 · 0 comments · Fixed by #185
Assignees
@daavoo
Labels
A: frameworks Area: ML Framework integration bug Did we break something? p0-critical Handle immediately testing

Comments

@daavoo
Copy link
Contributor

daavoo commented Nov 3, 2021

Recent catalyst versions changed the default formatting of the metrics, based on topk argument: catalyst-team/catalyst#1330

We check for explicit accuracy.tsv file which no longer has that name.
@daavoo daavoo added bug Did we break something? testing p0-critical Handle immediately labels Nov 3, 2021
@daavoo daavoo self-assigned this Nov 3, 2021
@daavoo daavoo mentioned this issue Nov 3, 2021
Merged
@daavoo daavoo added the A: frameworks Area: ML Framework integration label Nov 3, 2021
daavoo added a commit that referenced this issue Nov 3, 2021
@daavoo
catalyst: Update accuracy check
821eb12 
Recent catalyst versions changed the default formatting of the metrics, based on topk argument: catalyst-team/catalyst#1330

Close #184
daavoo added a commit that referenced this issue Nov 3, 2021
@daavoo
catalyst: Update accuracy check
9bca1e8 
Recent catalyst versions changed the default formatting of the metrics, based on topk argument: catalyst-team/catalyst#1330

Close #184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daavoo daavoo

Labels
A: frameworks Area: ML Framework integration bug Did we break something? p0-critical Handle immediately testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

catalyst: Update accuracy check iterative/dvclive
1 participant
@daavoo