Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type of --expdir param in catalyst-dl run updated to str #1338

Merged
merged 2 commits into from
Oct 30, 2021

Conversation

bagxi
Copy link
Member

@bagxi bagxi commented Oct 28, 2021

Pull Request FAQ

Description

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Checklist

  • Have you updated tests for the new functionality?
  • Have you added your new classes/functions to the docs?
  • Have you updated the CHANGELOG?
  • Have you run colab minimal CI/CD with latest and minimal requirements?
  • Have you checked XLA integration with single and multiple processes?

@bagxi bagxi requested a review from ditwoo as a code owner October 28, 2021 20:56
@bagxi bagxi self-assigned this Oct 28, 2021
@bagxi bagxi requested a review from Scitator as a code owner October 28, 2021 20:56
@Scitator Scitator merged commit 0e7fdbf into master Oct 30, 2021
@mergify mergify bot deleted the fix/expdir branch October 30, 2021 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants