Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: type of --expdir param in catalyst-dl run updated to str #1338

Merged
merged 2 commits into from
Oct 30, 2021
Merged

fix: type of --expdir param in catalyst-dl run updated to str #1338

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2cc4b7
fix: type of `--expdir` param in `catalyst-dl run` updated to `str`
bagxi Oct 28, 2021
7ff6a4a
Merge branch 'master' into fix/expdir
Scitator Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions catalyst/dl/scripts/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import argparse
from argparse import ArgumentParser
import os
from pathlib import Path
import sys

from catalyst.dl.scripts.misc import parse_args_uargs
Expand All @@ -29,7 +28,7 @@ def build_args(parser: ArgumentParser):
dest="configs",
required=False,
)
parser.add_argument("--expdir", type=Path, default=None)
parser.add_argument("--expdir", type=str, default=None)
parser.add_argument("--logdir", type=str, default=None)
parser.add_argument("--baselogdir", type=str, default=None)
# parser.add_argument(
Expand Down